Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video opened through rerun looks distorted and has wrong colors #7973

Closed
pablovela5620 opened this issue Nov 1, 2024 · 4 comments · Fixed by #7978
Closed

Video opened through rerun looks distorted and has wrong colors #7973

pablovela5620 opened this issue Nov 1, 2024 · 4 comments · Fixed by #7978
Assignees
Labels
🪳 bug Something isn't working 🎞️ video

Comments

@pablovela5620
Copy link
Contributor

Describe the bug

Something went wrong with showing an av1 encoded video. Here are is what it looks like in rerun and what it looks like in vlc

Rerun

Screen.Recording.2024-11-01.at.1.59.24.PM.mov

VLC

Screen.Recording.2024-11-01.at.1.59.48.PM.mov

To Reproduce
Steps to reproduce the behavior:

  1. Open video via rerun $Path to video

here is the video that I used that caused problems
https://huggingface.co/datasets/pablovela5620/rerun-bug-video/blob/main/combined-av1.mp4

Desktop (please complete the following information):

  • OS: Mac OS 15.1 (24B83)

Rerun version

rerun-cli 0.19.0 [rustc 1.79.0 (129f3b996 2024-06-10), LLVM 18.1.7] aarch64-apple-darwin, built 2024-10-21T16:15:46Z
Video features: av1 nasm

Additional context
This was after I merged some mp4 files and reenocded them to av1 using the following command

ffmpeg -i combined.mp4 -c:v libsvtav1 -preset 10 -crf 35 -c:a copy combined-av1.mp4
@pablovela5620 pablovela5620 added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Nov 1, 2024
@emilk emilk added 🎞️ video and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 2, 2024
@emilk
Copy link
Member

emilk commented Nov 2, 2024

I get the same problem on the native build:
Screenshot 2024-11-02 at 09 16 56

The web-viewer plays it perfectly though

Zooming in:
Screenshot 2024-11-02 at 09 18 31

Looks like something goes wrong with the chroma upsampling 🤔 Other 4:2:0 videos look correct though, so I wonder if this is a bug in rav1d, i.e. reporting the wrong chroma format?

@emilk emilk added this to the 0.20 - Maps, H.264 milestone Nov 2, 2024
@emilk
Copy link
Member

emilk commented Nov 2, 2024

Oh shit, I missed this:

Screenshot 2024-11-02 at 09 22 41

This is therefore a duplicate of:

It makes me think we should just refuse to play such videos though, instead of showing something so obviously wrong

@emilk emilk self-assigned this Nov 2, 2024
@emilk
Copy link
Member

emilk commented Nov 2, 2024

I'll add a warning to the selection panel, and maybe see if there is an easy way to at least get almost correct colors

@pablovela5620
Copy link
Contributor Author

For some reason I also didn't see the pop up on my mac, when I tested on my linux machine it showed up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🎞️ video
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants