Skip to content

Commit

Permalink
rerun linter fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Oct 9, 2024
1 parent 3888dab commit a25cc74
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace rerun.datatypes;

// TODO(andreas): Clarify relationship to color primaries.
// Suggestion: guides heuristic but doesn't specify it unless explicitely noted.
// Suggestion: guides heuristic but doesn't specify it unless noted.

/// Specifieds a particular format of an [archetypes.Image].
///
Expand Down Expand Up @@ -79,7 +79,7 @@ enum PixelFormat: ubyte {
/// the resolution of the Y plane.
Y_U_V12_FullRange = 44,

/// `NV12` (aka `Y_UV12`) is a YUV 4:2:0 chroma downsampled form at with 12 bits per pixel and 8 bits per channel.
/// `NV12` (aka `Y_UV12`) is a YUV 4:2:0 chroma downsampled form at with 12 bits per pixel and 8 bits per channel.
///
/// This uses limited range YUV, i.e. Y is valid in [16, 235] and U/V [16, 240].
/// Outside of it is clamped.
Expand Down
4 changes: 2 additions & 2 deletions crates/store/re_types/src/datatypes/pixel_format.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/store/re_video/src/decode/av1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ fn output_picture(picture: &dav1d::Picture, on_output: &(dyn Fn(Result<Frame>) +
// - transfer_characteristics

if picture.color_range() != dav1d::pixel::YUVRange::Limited {
// re_renderer's conversion use always li qmimted color range since this is the much more common case for YUV material.
// re_renderer's conversion use always li qmimted color range since this is the much more common case for YUV material.
re_log::warn_once!("Video specified full color range. Rerun only handles limited range right now. Colors may be slightly wrong as a conseqeuence.");
}

Expand Down Expand Up @@ -152,7 +152,7 @@ fn get_color_primaries(picture: &dav1d::Picture) -> ColorPrimaries {
// ColorPrimaries::Bt601
// }
//
// ... then again, eyeballing VLC it looks like it just always assumes BT.709.
// then again, eyeballing VLC it looks like it just always assumes BT.709.
// The handwavy test case employed here was the same video in low & high resolution
// without specified primaries. Both looked the same.
ColorPrimaries::Bt709
Expand Down
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/pixel_format.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_py/rerun_sdk/rerun/datatypes/pixel_format.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a25cc74

Please sign in to comment.