Skip to content

Commit

Permalink
typo fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Oct 9, 2024
1 parent 472f5aa commit 3888dab
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ use super::ColorPrimaries;

/// Supported chroma subsampling input formats.
///
/// We use `YUV`/`YCbCr`/`YPbPr` interchangably and usually just call it `YUV`.
/// We use `YUV`/`YCbCr`/`YPbPr` interchangeably and usually just call it `YUV`.
///
/// According to this [source](https://www.retrosix.wiki/yuv-vs-ycbcr-vs-rgb-color-space/):
/// * `YUV` is an analog signal
/// * `YCbCr` is scaled and offseted version of YUV, used in digital signals (we denote this as "limited range YUV")
/// * `YCbCr` is scaled and offsetted version of YUV, used in digital signals (we denote this as "limited range YUV")
/// * `YPbPr` is the physical component cabel to transmit `YCbCr`
/// Actual use in the wild seems to be all over the place.
/// For instance `OpenCV` uses `YCbCr` when talking about the full range and YUV when talking about
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ pub fn texture_creation_desc_from_color_image<'a>(
let format = match pixel_format {
// For historical reasons, using Bt.709 for fully planar formats and Bt.601 for others.
//
// TODO(andreas): Investigate if there's underlying expecation for some of these (for instance I suspect that NV12 is "usually" BT601).
// TODO(andreas): Investigate if there's underlying expectation for some of these (for instance I suspect that NV12 is "usually" BT601).
// TODO(andreas): Expose color primaries. It's probably still the better default (for instance that's what jpeg still uses),
// but should confirm & back that up!
//
Expand Down

0 comments on commit 3888dab

Please sign in to comment.