Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B) CLI path and parsing improvements. #29

Closed
wants to merge 13 commits into from

Conversation

yo1dog
Copy link
Contributor

@yo1dog yo1dog commented Sep 8, 2022

This PR is child of #28. To see diff with parent:
yo1dog/gekkoboot@yo1dog/prep-code-reorg...yo1dog/cli-parsing

  • Improves the algo used to parse CLI option strings.
    • Now ignores insignificant white space.
  • Improves logic for generating CLI filepath.
    • Now checks if DOL filepath ends with .dol before replacing last 3 characters with cli.

Rather than simply looking for line EOL characters, this algo tracks the position of the first and last non-whitespace character seen. Once an EOL or NULL character is found, we use the first and last non-whitespace characters to define the argument. Then state is reset.

@yo1dog yo1dog mentioned this pull request Sep 8, 2022
@yo1dog yo1dog changed the title CLI path and parsing improvements. B) CLI path and parsing improvements. Sep 8, 2022
@9ary 9ary force-pushed the master branch 10 times, most recently from 6e0d618 to 15f665f Compare December 3, 2023 21:34
@9ary 9ary closed this Mar 16, 2024
@yo1dog yo1dog deleted the yo1dog/cli-parsing branch October 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants