-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A) Code reorganization/preparation. #28
Conversation
6e0d618
to
15f665f
Compare
Hey @yo1dog! Sorry I never really got around to looking at your changes. I've only glanced at them so far but I'm not sure I want to merge them as they are. I've actually been working on iplboot for the past week and released r9 today. I've drafted a wish list for r10 in #40. Some of the features that you've implemented are on there. Feel free to comment there if you feel like I've missed something, or have any ideas on how some of those things should work. I don't think I'm going to accept code contributions until after all of this is done. |
Hey @9ary Been a long time for me as well! I will rebase all these onto master. If for no other reason than so I can keep my fork up to date. Happy to discuss wherever is most appropriate. If you have any high-level thoughts let me know or we can wait until after I rebase so we can talk specific code changes. |
Welcome back! Feel free to rebase and resubmit, as you can see in #40 a lot of this is planned so I'll gladly take the help. I'd like to do a bit of housekeeping like formatting the code, but that shouldn't prevent you from working in the meantime. |
Reformatting beforehand helps reduce merge conflicts later. Do you have a prettier or auto formatter config you use?
…________________________________
From: novenary ***@***.***>
Sent: Wednesday, October 23, 2024 5:37:43 AM
To: redolution/gekkoboot ***@***.***>
Cc: Mike ***@***.***>; Mention ***@***.***>
Subject: Re: [redolution/gekkoboot] A) Code reorganization/preparation. (PR #28)
Welcome back! Feel free to rebase and resubmit, as you can see in #40<#40> a lot of this is planned so I'll gladly take the help.
I'd like to do a bit of housekeeping like formatting the code, but that shouldn't prevent you from working in the meantime.
—
Reply to this email directly, view it on GitHub<#28 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALPKVNFRI6QXYRVHOPUBA3Z4537HAVCNFSM6AAAAAAQHP3VYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGY4TANJSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This pull request does not change any functionality. It cleans up the code base in preparation for incoming pull requests. Specifically, config file support.
This one is still pretty big, but the rest should be much lighter.