Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A) Code reorganization/preparation. #28

Closed
wants to merge 11 commits into from

Conversation

yo1dog
Copy link
Contributor

@yo1dog yo1dog commented Sep 8, 2022

This pull request does not change any functionality. It cleans up the code base in preparation for incoming pull requests. Specifically, config file support.

  • Code that is or will be called from multiple locations has been abstracted into functions.
  • Some code is organized into separate files as main.c was growing quite large.
  • Global state was removed (and function interfaces updated accordingly).
  • Some complex function interfaces were simplified using structs.
  • De-linted to conform with established coding style.

This one is still pretty big, but the rest should be much lighter.

@yo1dog yo1dog changed the title Code reorganization/preparation. A) Code reorganization/preparation. Sep 8, 2022
@9ary 9ary force-pushed the master branch 10 times, most recently from 6e0d618 to 15f665f Compare December 3, 2023 21:34
@9ary
Copy link
Member

9ary commented Dec 6, 2023

Hey @yo1dog!

Sorry I never really got around to looking at your changes. I've only glanced at them so far but I'm not sure I want to merge them as they are. I've actually been working on iplboot for the past week and released r9 today.

I've drafted a wish list for r10 in #40. Some of the features that you've implemented are on there. Feel free to comment there if you feel like I've missed something, or have any ideas on how some of those things should work.

I don't think I'm going to accept code contributions until after all of this is done.

@yo1dog
Copy link
Contributor Author

yo1dog commented Oct 22, 2024

Hey @9ary

Been a long time for me as well! I will rebase all these onto master. If for no other reason than so I can keep my fork up to date.

Happy to discuss wherever is most appropriate. If you have any high-level thoughts let me know or we can wait until after I rebase so we can talk specific code changes.

@9ary
Copy link
Member

9ary commented Oct 23, 2024

Welcome back! Feel free to rebase and resubmit, as you can see in #40 a lot of this is planned so I'll gladly take the help.

I'd like to do a bit of housekeeping like formatting the code, but that shouldn't prevent you from working in the meantime.

@yo1dog
Copy link
Contributor Author

yo1dog commented Oct 23, 2024 via email

@yo1dog yo1dog deleted the yo1dog/prep-code-reorg branch October 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants