Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync buildah-oci-ta to be based upon 0.3 #2337

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

sswguo
Copy link
Contributor

@sswguo sswguo commented Jan 13, 2025

Updates based on the diffs with buildah-oci-ta 0.3.

@openshift-ci openshift-ci bot requested review from rnc and vibe13 January 13, 2025 03:26
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

Hi @sswguo. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.10%. Comparing base (3c696ce) to head (e23b15b).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2337   +/-   ##
=========================================
  Coverage     44.10%   44.10%           
  Complexity      785      785           
=========================================
  Files           278      278           
  Lines         13349    13349           
  Branches       1339     1339           
=========================================
  Hits           5888     5888           
  Misses         6867     6867           
  Partials        594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnc
Copy link
Collaborator

rnc commented Jan 13, 2025

@sswguo Can this be rebased please (for some reason the minikube failed to trigger)

@sswguo
Copy link
Contributor Author

sswguo commented Jan 14, 2025

@sswguo Can this be rebased please (for some reason the minikube failed to trigger)

sure.

@sswguo
Copy link
Contributor Author

sswguo commented Jan 14, 2025

Seems that test is still not triggered.

@rnc rnc force-pushed the buildah_updates branch from e23b15b to a569828 Compare January 14, 2025 07:55
@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 14, 2025
@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/ok-to-test

@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

I've seen the failures and I think it needs a rebase on top of #2336 once that is merged.

@rnc rnc force-pushed the buildah_updates branch from a569828 to d92a971 Compare January 14, 2025 11:23
@openshift-ci openshift-ci bot removed the lgtm label Jan 14, 2025
@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 14, 2025
@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/ok-to-test

@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@sswguo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/jvm-build-service-in-repo-e2e d92a971 link true /test jvm-build-service-in-repo-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rnc
Copy link
Collaborator

rnc commented Jan 14, 2025

/retest

@rnc rnc merged commit b1832c0 into redhat-appstudio:main Jan 14, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants