-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync buildah-oci-ta to be based upon 0.3 #2337
Conversation
Hi @sswguo. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
=========================================
Coverage 44.10% 44.10%
Complexity 785 785
=========================================
Files 278 278
Lines 13349 13349
Branches 1339 1339
=========================================
Hits 5888 5888
Misses 6867 6867
Partials 594 594 ☔ View full report in Codecov by Sentry. |
1580b62
to
efab85c
Compare
@sswguo Can this be rebased please (for some reason the minikube failed to trigger) |
c301bb1
to
e23b15b
Compare
sure. |
Seems that test is still not triggered. |
/lgtm |
/ok-to-test |
I've seen the failures and I think it needs a rebase on top of #2336 once that is merged. |
/lgtm |
/ok-to-test |
/retest |
@sswguo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
Updates based on the diffs with buildah-oci-ta 0.3.