Feature/debian12 #502
Merged
Feature/debian12 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 11, 2024 11:45
…Add some type hints. Updated Lief version. Fixed tests. Stopped using package-manager toolchains.
…from /tmp after building toolchains.
This was referenced Dec 4, 2024
Closed
|
@paulnoalhyt, can you work through the merge conflicts on this one? |
rbs-jacob
previously requested changes
Dec 12, 2024
Co-authored-by: Jacob Strieb <[email protected]>
paulnoalhyt
commented
Dec 16, 2024
whyitfor
requested changes
Dec 17, 2024
whyitfor
dismissed
rbs-jacob’s stale review
I have validated that all requested changes made it into the PR.
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
After a few attempts (#467 and #494), another try at moving to Debian 12.
Link to Related Issue(s)
#495
Please describe the changes in your request.
This time updating base Docker image to python3.9 and installing toolchains from files instead of package manager. Had to update Lief (old version was causing Binary Ninja to segfault). Fixed tests along the way.
Anyone you think should look at this, specifically?
@whyitfor