Inherit link color in components using the Feedback color collection (#492) #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
commented
Sep 2, 2024
adamkudrna
force-pushed
the
refactor/use-color-collections
branch
from
69d7426 to
4c40045
Compare
adamkudrna
force-pushed
the
feature/inherit-link-color
branch
from
856f555 to
6e26fba
Compare
mbohal
reviewed
Oct 8, 2024
|
I'm going to give approve , but honestly I'm unsure if we should merge this without resolving #577 . |
mbohal
approved these changes
Nov 30, 2024
adamkudrna
force-pushed
the
feature/inherit-link-color
branch
from
6d92391 to
bac1e21
Compare
Links in `Alert` now inherit the font weight which is consistent with other links in React UI.
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlertandCard, link color changes by component variant.See #492.