-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inherit link color in components with feedback/validation states #492
Comments
@davidurban proposes that the local context color should be used everywhere where the context element can changes color to provide some information to the user. |
Thank you for your proposal. However, we need to discuss it a bit more deeply before we can dispatch it to engineering.
|
I also think we will need to eventually start supporting feedback colours on most components (like Paper, Modal, Tabs…) because of needs of Generated UIs. There a node (represented by Paper, or Tap) can become invalid and we will need to visually indicate it. Having ability to use Feedback Colours would greatly improve DX and consistency. In such cases, container links should also inherit the colour. |
Generally I think the same. |
🎯 — to be done in this issue |
…e Feedback color collection (#492)
…sing the Feedback color collection (#492)
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
Since the color inheritance for links has been introduced in #492, links in e.g. validation messages cannot be distinguished from regular text until hovered. We chose to underline all text links by default to make those links discoverable by users.
When we use the
<TextLink>
component inside an<Alert>
element, it uses the context color (from<Alert>
) instead of the default link color (from<TextLink>
).However in other contexts this is not the case for other elements:
We need to somehow unify this behavior across all our components.
The text was updated successfully, but these errors were encountered: