Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit link color in components with feedback/validation states #492

Closed
mbohal opened this issue Sep 19, 2023 · 5 comments · Fixed by #565
Closed

Inherit link color in components with feedback/validation states #492

mbohal opened this issue Sep 19, 2023 · 5 comments · Fixed by #565
Assignees
Labels
Milestone

Comments

@mbohal
Copy link
Contributor

mbohal commented Sep 19, 2023

When we use the <TextLink> component inside an <Alert> element, it uses the context color (from <Alert>) instead of the default link color (from <TextLink>).

image

However in other contexts this is not the case for other elements:

image

We need to somehow unify this behavior across all our components.

@mbohal
Copy link
Contributor Author

mbohal commented Sep 19, 2023

@davidurban proposes that the local context color should be used everywhere where the context element can changes color to provide some information to the user.

@mbohal mbohal added the feature label Sep 19, 2023
@mbohal mbohal added this to The Board Sep 19, 2023
@mbohal mbohal moved this from 💡Ideas to 🔖 To do in The Board Sep 19, 2023
@github-project-automation github-project-automation bot moved this to 💡Ideas in The Board Sep 19, 2023
@adamkudrna adamkudrna self-assigned this Sep 22, 2023
@adamkudrna
Copy link
Member

Thank you for your proposal. However, we need to discuss it a bit more deeply before we can dispatch it to engineering.

  1. We need to clarify what means "everywhere [where the context element can changes color]". There are two relevant situations:
    1. components that use Feedback Colors (but there components with both light (Alert) and dark (Badge) background, what then?),
    2. components that use Validation State Colors (but there is also the default state, see the input on the left).
  2. We need to decide if links in the default validation state should be gray too — that's a BC.
  3. RUI only: should the color inheritance feature be optional globally / per component / not at all?

@adamkudrna adamkudrna moved this from 🔖 To do to 💡Ideas in The Board Oct 16, 2023
@davidurban
Copy link

  1. Agree with both.
  2. They should not be gray, but default TextLink colour (theme.colors.primary).
  3. No opinion.

I also think we will need to eventually start supporting feedback colours on most components (like Paper, Modal, Tabs…) because of needs of Generated UIs. There a node (represented by Paper, or Tap) can become invalid and we will need to visually indicate it. Having ability to use Feedback Colours would greatly improve DX and consistency. In such cases, container links should also inherit the colour.

@mbohal
Copy link
Contributor Author

mbohal commented Oct 17, 2023

we will need to eventually start supporting feedback colours on most components (like Paper, Modal, Tabs…)

Generally I think the same.

@adamkudrna adamkudrna changed the title Inherit link color Inherit link color in components with feedback/validation states Aug 22, 2024
@adamkudrna
Copy link
Member

adamkudrna commented Aug 26, 2024

Component Action Colors Feedback Colors Neutral Colors Validation Colors Link Color Inheritance
Alert
Badge
Button
ButtonGroup
Card 🎯
CheckboxField 🎯
FileInputField 🎯
FormLayout
Grid
InputGroup
Modal #468 #468
Paper 🔮
Popover
Radio 🎯
ScrollView
SelectField 🎯
Table
Tabs 🔮
Text
TextArea 🎯
TextField 🎯
TextLink
Toggle 🎯
Toolbar

🎯 — to be done in this issue
🔮 — to be done in the future

@adamkudrna adamkudrna added this to the v1.0.0 milestone Sep 2, 2024
adamkudrna added a commit that referenced this issue Oct 8, 2024
adamkudrna added a commit that referenced this issue Nov 27, 2024
adamkudrna added a commit that referenced this issue Nov 29, 2024
@adamkudrna adamkudrna moved this from 🏗 In progress to 👀 In review in The Board Nov 29, 2024
adamkudrna added a commit that referenced this issue Dec 2, 2024
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
adamkudrna added a commit that referenced this issue Dec 6, 2024
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
adamkudrna added a commit that referenced this issue Dec 6, 2024
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
adamkudrna added a commit that referenced this issue Dec 6, 2024
Since the color inheritance for links has been introduced
in #492, links in e.g. validation messages cannot be
distinguished from regular text until hovered. We chose
to underline all text links by default to make those links
discoverable by users.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in The Board Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants