Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Listeners not honoring multiple failures for subscription #202

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Fix: Listeners not honoring multiple failures for subscription #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b22383d
Initial commit. Removing listener from promise list
parag-pv Aug 5, 2024
8da9b08
Using the existing remove function instead. Updated comment
parag-pv Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion languages/javascript/src/shared/Events/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,16 @@ const doListen = function(module, event, callback, context, once, internal=false
resolve(listenerId)
}
else {
// Remove the listener from external list on failure to subscribe
// TODO: Instead of removing, the failed subscription shouldn't be put into the external list
listeners.remove(listenerId)
reject(error)
}
})
}
else {
resolve(listenerId)
}

return p
}
}
Expand Down
Loading