Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Listeners not honoring multiple failures for subscription #202

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

parag-pv
Copy link
Contributor

@parag-pv parag-pv commented Aug 5, 2024

Problem:

If a call fails when subscribing, the caller will get an error back.
However if they call again, then the caller will see success despite the listener never actually getting set.

Fix:

Remove the listener from promise list if failure

@parag-pv parag-pv requested a review from kschrief August 5, 2024 15:34
@parag-pv parag-pv changed the title Fix for listeners not honoring multiple failures for subscription Fix: Listeners not honoring multiple failures for subscription Aug 5, 2024
@kschrief kschrief merged commit 0c00896 into next Aug 7, 2024
6 checks passed
@kschrief kschrief deleted the fix/listener-reg-error branch August 7, 2024 18:20
@kschrief
Copy link
Contributor

kschrief commented Aug 8, 2024

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kschrief
Copy link
Contributor

kschrief commented Aug 8, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants