Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price feed request for SKL token #75

Closed
wants to merge 4 commits into from
Closed

Price feed request for SKL token #75

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eaf8e9c
SKL USD price feed
manuelbarbas Oct 13, 2023
3195d64
binance remove
manuelbarbas Oct 13, 2023
ce455aa
removed XHTML coingecko selector
manuelbarbas Oct 16, 2023
a7263f1
requested fixes by razor team
manuelbarbas Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mainnet/collections.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,12 @@
"power": 2,
"name": "ETHUSD",
"tolerance": 500000
},
{
"jobIDs": [11, 12, 13, 14, 15],
"aggregationMethod": 2,
"power": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update power for all SKALE jobs to 6, you need to update the power for collection to 6 as well
@manuelbarbas

"name": "SKLUSD",
"tolerance": 500000
}
]
40 changes: 40 additions & 0 deletions mainnet/jobs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,5 +78,45 @@
"name": "ethusd_cryptocompare",
"selector": "[USD]",
"url": "https://min-api.cryptocompare.com/data/price?fsym=ETH&tsyms=USD"
},
{
"weight": 1,
"power": 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update power for all these SKALE jobs to 6 for better precision
@manuelbarbas

"selectorType": 0,
"name": "sklusd_gemini",
"selector": "last",
"url": "https://api.gemini.com/v1/pubticker/sklusd"
},
{
"weight": 1,
"power": 2,
"selectorType": 0,
"name": "sklusd_kucoin",
"selector": "data.SKL",
"url": "https://api.kucoin.com/api/v1/prices?base=USD&currencies=SKL"
},
{
"weight": 1,
"power": 2,
"selectorType": 0,
"name": "sklusd_coinbase",
"selector": "data.amount",
"url": "https://api.coinbase.com/v2/prices/SKL-USD/spot"
},
{
"weight": 1,
"power": 2,
"selectorType": 0,
"name": "sklusd_coingecko_api",
"selector": "skale.usd",
"url": "https://api.coingecko.com/api/v3/simple/price?ids=skale&vs_currencies=usd"
},
{
"weight": 1,
"power": 2,
"selectorType": 0,
"name": "sklusd_cryptocompare",
"selector": "[USD]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the selector should be USD instead of [USD] to get the correct value from API.

"url": "https://min-api.cryptocompare.com/data/price?fsym=SKL&tsyms=USD"
}
]