Price feed request for SKL token #75
Conversation
|
hey @manuelbarbas there are some conflicts that need to be resolved. Could you rebase with upstream master, thank you! |
| "power": 2, | ||
| "selectorType": 0, | ||
| "name": "sklusd_cryptocompare", | ||
| "selector": "[USD]", |
There was a problem hiding this comment.
Here the selector should be USD instead of [USD] to get the correct value from API.
mainnet/jobs.json
Outdated
| }, | ||
| { | ||
| "weight": 1, | ||
| "power": 2, |
There was a problem hiding this comment.
Can you update power for all these SKALE jobs to 6 for better precision
@manuelbarbas
mainnet/collections.json
Outdated
| { | ||
| "jobIDs": [11, 12, 13, 14, 15], | ||
| "aggregationMethod": 2, | ||
| "power": 2, |
There was a problem hiding this comment.
If you update power for all SKALE jobs to 6, you need to update the power for collection to 6 as well
@manuelbarbas
|
Hey @Yashk767 Just added the requested changes. Thank you |
| @@ -1,82 +1,122 @@ | |||
| [ | |||
| { | |||
| "weight": 1, | |||
| "power": 2, | |||
| "power": 6, | |||
There was a problem hiding this comment.
hey @manuelbarbas the power for eth jobs should remain unchanged, it was only required for the SKL token.
|
Stale PR, the PR to add SKL token needs to be recreated @manuelbarbas |
name: Price feed request
about: ""
title: "SKL data feed"
labels: ""
assignees: ""
Description
SKLdata feed added.
I updated jobs.json and collections.json according to contributing guide.
Type of change
Please mark the options that apply to this PR.
Checklist: