Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cuco version to fetch various fixes and new features #723

Open
wants to merge 7 commits into
base: branch-25.02
Choose a base branch
from
Open

Bump cuco version to fetch various fixes and new features #723

wants to merge 7 commits into from

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Dec 3, 2024 •
edited
Loading

Description

This PR bumps the cuco version to mainly fetch the bucket storage update and bloom filter fixes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel PointKernel added non-breaking Introduces a non-breaking change 2 - In Progress Currenty a work in progress improvement Improves an existing functionality labels Dec 3, 2024
@PointKernel PointKernel self-assigned this Dec 4, 2024
@PointKernel
Copy link
Member Author

PointKernel commented Dec 4, 2024 •
edited
Loading

Downstream tests verifying the new cuco:

@PointKernel PointKernel mentioned this pull request Dec 4, 2024
Open
3 tasks
@PointKernel PointKernel added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Dec 12, 2024
@PointKernel PointKernel marked this pull request as ready for review December 12, 2024 23:47
@PointKernel PointKernel requested a review from a team as a code owner December 12, 2024 23:47
@PointKernel
Copy link
Member Author

All downstream tests passed and this is ready for review.

@bdice
Copy link
Contributor

bdice commented Dec 13, 2024 •
edited
Loading

@vyasr Do these failures look familiar to you? I’m wondering if dropping spdlog from rmm broke something.

@PointKernel PointKernel added 3 - Ready for Review Ready for review by team and removed 3 - Ready for Review Ready for review by team labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees

@PointKernel PointKernel

Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @bdice