Support reading bloom filters from Parquet files and filter row groups using them #17289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaseeb123
added
2 - In Progress
vuule
reviewed
Dec 12, 2024
3 tasks
Draft
5 tasks
…ty operators in the expression
mhaseeb123
commented
Dec 13, 2024
| ast_operator::NOT, _bloom_filter_expr.push(ast::operation{ast_operator::NOT, value})}); | ||
| } | ||
| // For all other expressions, push an always true expression | ||
| else { |
There was a problem hiding this comment.
@karthikeyann @vuule added this logic handle any non col == lit type expressions in the filter. Essentially just transforming them all to always true.
mhaseeb123
commented
Dec 13, 2024
| * @brief Collects lists of equality predicate literals in the AST expression, one list per input | ||
| * table column. This is used in row group filtering based on bloom filters. | ||
| */ | ||
| class equality_literals_collector : public ast::detail::expression_transformer { |
There was a problem hiding this comment.
No need for an ast::tree in this expression converter as we only visit and collect literals for col == lit expressions.
mhaseeb123
commented
Dec 13, 2024
| */ | ||
| std::reference_wrapper<ast::expression const> visit(ast::literal const& expr) override | ||
| { | ||
| return expr; |
There was a problem hiding this comment.
No need to push any of these to the ast::tree from the child class bloom_filter_expression_converter either as these columns or literals don't participate in the transformed expression tree.
vuule
approved these changes
Dec 13, 2024
Co-authored-by: Vukasin Milovanovic <[email protected]>
mhaseeb123
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support to read bloom filters from Parquet files and use them to filter row groups based on
col == literallike predicate(s), if provided.Related to #17164
Checklist