2412 remove libraft vss instantiations #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
benfred
approved these changes
Nov 15, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
bdice
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Thanks for all the effort here. I pushed a few small fixes, and have a few questions for follow up work:
- Do we want to delete
cpp/template/cmake/thirdparty/get_raft.cmake? It is the only file left incpp/template/*. If we do remove it, we also need to clean up a reference inci/release/update-version.sh. - Are we able to purge all remaining instances of
RAFT_EXPLICIT_INSTANTIATE_ONLY? There are quite a few files still mentioning this, but I think all of these are deprecated and thus we should be able to removeRAFT_EXPLICIT_INSTANTIATE_ONLY? Also this section of the docs could be removed or greatly simplified, I think. https://github.com/rapidsai/raft/blob/branch-24.12/docs/source/developer_guide.md#header-organization-of-expensive-function-templates - There are quite a few remaining references to
#include <hnswlib/hnswlib.h>but we are no longer including the CMake code to find hnswlib. Is that a problem? Are these features usable (despite being unsupported) in the current state? I would not expect them to work anymore. It might make more sense to just purge all of this, because there's no use in keeping headers that aren't going to work with the current build system / missing dependencies.
|
|
/merge |
This was referenced Nov 18, 2024
I filed #2500 to address this. |
benfred
added a commit
to benfred/cuvs
that referenced
this pull request
Nov 18, 2024
With the changes in rapidsai/raft#2498 we no longer have a pylibraft.neighbors module - but were still using a utility function `_check_input_array` from it in cuvs. Move this over to cuvs to unblock ci
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Nov 18, 2024
With the changes in rapidsai/raft#2498 we no longer have a pylibraft.neighbors module - but were still using a utility function `_check_input_array` from it in cuvs. Move this over to cuvs to unblock ci Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #474
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Follow-up to #2498 (comment). This removes an extraneous file in `cpp/template` that resulted from an incorrect merge conflict resolution and a leftover reference to the template project in `update-version.sh`. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2500
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Following #2498, we can apply this feedback from #2490: #2490 (comment) These changes are inspired by rapidsai/cuvs#469. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are keeping random ball cover headers in RAFT for 24.12, and random ball cover depends on distances and brute-force. Because of this, we're going to leave all of the VSS headers in RAFT for the time being, and will remove them all in a future PR once RBC is formally migrated to cuVS. The tests, benchmarks, and instantiations for all of these APIs will be removed, though, so while the actual headers can still be used, they are no longer being tested and could fail without warning.
I've also included a note to users in the README about this, stating to use at their own risk.