Disable hnswlib if not compiling shared library components of RAFT #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
improvement
lowener
reviewed
Nov 18, 2024
| @@ -605,6 +602,7 @@ if(RAFT_COMPILE_LIBRARY) | |||
| ${RAFT_CTK_MATH_DEPENDENCIES} # TODO: Once `raft::resources` is used everywhere, this | |||
| # will just be cublas | |||
| $<TARGET_NAME_IF_EXISTS:OpenMP::OpenMP_CXX> | |||
| $<TARGET_NAME_IF_EXISTS:hnswlib::hnswlib> | |||
There was a problem hiding this comment.
If the user wants to build with HNSW but the target name does not exist will there be an error or will it fail silently? A bad scenario would be to compile the whole library only to find that hnswlib was not included in this compilation when it was explicitly requested.
|
Is this PR still relevant after #2498? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in rapidsai/cuvs#465 when building newer versions of hnswlib, version conflicts are found to be not resolvable. The effect of this PR will be that
libraft-headersconda package will not be configured withhnswlib.