Introduction of the raft::device_resources_snmg type
#2487
+236
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.12 #2487 +/- ##
=============================================
Coverage 81.16% 81.16%
=============================================
Files 19 19
Lines 515 515
=============================================
Hits 418 418
Misses 97 97 ☔ View full report in Codecov by Sentry. |
cjnolet
reviewed
Nov 8, 2024
cjnolet
reviewed
Nov 8, 2024
cjnolet
reviewed
Nov 8, 2024
viclafargue
changed the title
raft::device_resources_snmg type
cjnolet
reviewed
Nov 18, 2024
cjnolet
reviewed
Nov 18, 2024
cjnolet
reviewed
Nov 18, 2024
cjnolet
reviewed
Dec 12, 2024
cjnolet
reviewed
Dec 12, 2024
cjnolet
reviewed
Dec 12, 2024
cjnolet
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Took another look and I think the implementation itself is great. The only suggestions I have are related to the docs. I understand this is a lower-level detail for most users but we should strive to provide as much info and details as possible for both end-users AND for future implementors of SNMG algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
raft::device_resources_snmgtype to hold all resources required for the NCCL clique.Answers #2459Removed call to
raft::comms::build_comms_nccl_only(#2465)