Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-json to pre-commit linters, and fix invalid ann-bench JSON config #1894

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Add check-json to pre-commit linters, and fix invalid ann-bench JSON config #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a81140
Add check-json to pre-commit linters, and fix invalid ann-bench JSON …
benfred Oct 12, 2023
1047031
Merge branch 'branch-23.12' into json_lint
benfred Oct 12, 2023
44131b8
bump check-json version, fix duplicate 'file' key error
benfred Oct 12, 2023
3cb768e
Merge branch 'json_lint' of github.com:benfred/raft into json_lint
benfred Oct 12, 2023
7676ba6
Merge branch 'branch-23.12' into json_lint
benfred Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ repos:
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]

- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.5.0
hooks:
- id: check-json

default_language_version:
python: python3
3 changes: 1 addition & 2 deletions python/raft-ann-bench/src/raft-ann-bench/run/conf/glove-100-inner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@
"algo": "faiss_gpu_ivf_flat",
"build_param": {"nlist":8192},
"file": "glove-100-inner/faiss_gpu_ivf_flat/nlist8192",
"file": "index/glove-100-inner/faiss_ivf_flat/nlist8192",
"search_params": [
{
"nprobe": 1
Expand Down Expand Up @@ -682,7 +681,7 @@
"algo": "faiss_gpu_flat",
"build_param": {},
"file": "glove-100-inner/faiss_gpu_flat/flat",
"search_params": [{}]
"search_params": [{}],
"search_result_file": "result/glove-100-inner/faiss_gpu_flat/flat"
},

Expand Down
2 changes: 1 addition & 1 deletion python/raft-ann-bench/src/raft-ann-bench/run/conf/mnist-784-euclidean.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
c{
{
"dataset": {
"name": "mnist-784-euclidean",
"base_file": "mnist-784-euclidean/base.fbin",
Expand Down