Add check-json to pre-commit linters, and fix invalid ann-bench JSON config #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files The ann-bench conf files had a couple of datasets with invalid JSON config files, causing them to fail to run. This adds a check-json pre-commit hook to detect invalid json, which would have failed on these files with: ``` python/raft-ann-bench/src/raft-ann-bench/run/conf/mnist-784-euclidean.json: Failed to json decode (Expecting value: line 1 column 1 (char 0)) python/raft-ann-bench/src/raft-ann-bench/run/conf/glove-100-inner.json: Failed to json decode (Expecting ',' delimiter: line 686 column 7 (char 15218)) ```
benfred
added
improvement
|
/merge |
divyegala
pushed a commit
to divyegala/raft
that referenced
this pull request
Oct 17, 2023
…config (rapidsai#1894) The ann-bench conf files had a couple of datasets with invalid JSON config files, causing them to fail to run. This adds a check-json pre-commit hook to detect invalid json, which would have failed on these files with: ``` python/raft-ann-bench/src/raft-ann-bench/run/conf/mnist-784-euclidean.json: Failed to json decode (Expecting value: line 1 column 1 (char 0)) python/raft-ann-bench/src/raft-ann-bench/run/conf/glove-100-inner.json: Failed to json decode (Expecting ',' delimiter: line 686 column 7 (char 15218)) ``` Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ann-bench conf files had a couple of datasets with invalid JSON config files, causing them to fail to run.
This adds a check-json pre-commit hook to detect invalid json, which would have failed on these files with: