Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new dataset for benchmarking in the 100k node 1M edge range, adds additional k-values for BC benchmarks #4726

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Oct 16, 2024

Adds new dataset for benchmarking in the 100k node 1M edge range.
This also updates the benchmark fixture to download the dataset instead of requiring a separate script.
This also includes changes from #4721 to add additional k-values for BC benchmarks to run.

The addition was done with an inline yaml file and a followup PR will be done to properly add this dataset to the cugraph.datasets API. The inline yaml was done in order to allow benchmarks to run on a system with an existing cugraph installation by simply copying this bench_algos.py, rather than require an updated cugraph install with the new dataset metadata.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 16, 2024
@rlratzel rlratzel requested a review from nv-rliu October 16, 2024 21:30
@rlratzel rlratzel self-assigned this Oct 16, 2024
Copy link
Contributor

@nv-rliu nv-rliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rlratzel rlratzel requested a review from a team as a code owner October 16, 2024 22:36
@rlratzel rlratzel changed the title Adds new dataset for benchmarking in the 100k node 1M edge range Adds new dataset for benchmarking in the 100k node 1M edge range, adds additional k-values for BC benchmarks Oct 16, 2024
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rlratzel
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0c81f15 into rapidsai:branch-24.12 Oct 17, 2024
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants