-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nx-cugraph
Benchmarks for Additional BC K-Values
#4721
Closed
nv-rliu
wants to merge
8
commits into
rapidsai:branch-24.12
from
nv-rliu:branch-24.12-update-bench-algos
Closed
Update nx-cugraph
Benchmarks for Additional BC K-Values
#4721
nv-rliu
wants to merge
8
commits into
rapidsai:branch-24.12
from
nv-rliu:branch-24.12-update-bench-algos
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-rliu
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Oct 15, 2024
rlratzel
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor changes.
Co-authored-by: Rick Ratzel <[email protected]>
rlratzel
approved these changes
Oct 15, 2024
We combined these changes into #4726 for easier testing by the benchmark team. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
…s additional k-values for BC benchmarks (#4726) Adds new dataset for benchmarking in the 100k node 1M edge range. This also updates the benchmark fixture to download the dataset instead of requiring a separate script. This also includes changes from #4721 to add additional k-values for BC benchmarks to run. The addition was done with an inline yaml file and a followup PR will be done to properly add this dataset to the cugraph.datasets API. The inline yaml was done in order to allow benchmarks to run on a system with an existing cugraph installation by simply copying this bench_algos.py, rather than require an updated cugraph install with the new dataset metadata. Authors: - Rick Ratzel (https://github.com/rlratzel) - Ralph Liu (https://github.com/nv-rliu) Approvers: - Ralph Liu (https://github.com/nv-rliu) - Don Acosta (https://github.com/acostadon) URL: #4726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmarks
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/rapidsai/graph_dl/issues/597
Proposed Changes:
bench_algos.py::bench_betweenness_centrality
.pytest -k
. When usingrun-main-benchmarks.sh
, there is abc-k-values
string that can be edited to perform the selection.README
update