Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nx-cugraph Benchmarks for Additional BC K-Values #4721

Closed

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Oct 15, 2024

Part of https://github.com/rapidsai/graph_dl/issues/597

Proposed Changes:

  • This PR adds additional k-values for bench_algos.py::bench_betweenness_centrality.
  • These k-values can be selected/turned off by using pytest -k. When using run-main-benchmarks.sh, there is a bc-k-values string that can be edited to perform the selection.
  • README update

@nv-rliu nv-rliu added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 15, 2024
@nv-rliu nv-rliu added this to the 24.12 milestone Oct 15, 2024
@nv-rliu nv-rliu requested a review from rlratzel October 15, 2024 16:17
@nv-rliu nv-rliu requested a review from a team as a code owner October 15, 2024 16:17
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor changes.

benchmarks/nx-cugraph/pytest-based/bench_algos.py Outdated Show resolved Hide resolved
benchmarks/nx-cugraph/pytest-based/run-main-benchmarks.sh Outdated Show resolved Hide resolved
@rlratzel
Copy link
Contributor

We combined these changes into #4726 for easier testing by the benchmark team.

@rlratzel rlratzel closed this Oct 16, 2024
rapids-bot bot pushed a commit that referenced this pull request Oct 17, 2024
…s additional k-values for BC benchmarks (#4726)

Adds new dataset for benchmarking in the 100k node 1M edge range.
This also updates the benchmark fixture to download the dataset instead of requiring a separate script.
This also includes changes from #4721 to add additional k-values for BC benchmarks to run. 

The addition was done with an inline yaml file and a followup PR will be done to properly add this dataset to the cugraph.datasets API.  The inline yaml was done in order to allow benchmarks to run on a system with an existing cugraph installation by simply copying this bench_algos.py, rather than require an updated cugraph install with the new dataset metadata.

Authors:
  - Rick Ratzel (https://github.com/rlratzel)
  - Ralph Liu (https://github.com/nv-rliu)

Approvers:
  - Ralph Liu (https://github.com/nv-rliu)
  - Don Acosta (https://github.com/acostadon)

URL: #4726
@nv-rliu nv-rliu deleted the branch-24.12-update-bench-algos branch November 18, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants