Use CategoricalColumn instead of build_categorical_column #4618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
BradReesWork
approved these changes
Aug 26, 2024
…schke/cugraph into rm/build_categorical_column
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Aug 28, 2024
…ctor (#16617) `build_categorical_column` was largely redundant with the CategoricalColumn constructor, so in the spirit of having One Way to Do Things, replacing the former with the latter. There is usage of `build_categorical_column` in cugraph that has been replaced in rapidsai/cugraph#4618 Authors: - Matthew Roeschke (https://github.com/mroeschke) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Richard (Rick) Zamora (https://github.com/rjzamora) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #16617
galipremsagar
approved these changes
Aug 28, 2024
jakirkham
added
improvement
|
A couple CI jobs errored due to what appeared to be PyPI network errors. Have restarted those |
This was referenced Aug 29, 2024
Merged
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in cudf, I'm planning on removing
build_categorical_columnin favor of theCategoricalColumnconstructor so adjusting the usage here