-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update a few more Python references to Python 3.10 #4637
update a few more Python references to Python 3.10 #4637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James! 🙏
There are some other references in the benchmarks and notebooks. That said, would leave those alone for now. Maybe we can raise an issue so the cuGraph team can follow up (as it may involve rerunning things)
Looks like one CI job had a network failure That said, cuDF made some changes that we need a fix for in cuGraph. This is already being handled in PR: #4618 So let's wait for that to land and then pull in upstream changes to retest |
Now that the aforementioned PR is in, updating this PR to include that fix and rerun CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good but there are some other issues we could correct at the same time.
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
/merge |
Sure @jakirkham , happy to. Opened #4640 |
Contributes to rapidsai/build-planning#88.
#4625 dropped Python 3.9 support here (as part of the RAPIDS-wide effort to drop Python 3.9 in this release). This PR fixes a few things that were missed in that PR.