Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update a few more Python references to Python 3.10 #4637

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#88.

#4625 dropped Python 3.9 support here (as part of the RAPIDS-wide effort to drop Python 3.9 in this release). This PR fixes a few things that were missed in that PR.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 28, 2024
@jameslamb jameslamb changed the title WIP: update a few more Python references to Python 3.10 update a few more Python references to Python 3.10 Aug 28, 2024
@jameslamb jameslamb marked this pull request as ready for review August 28, 2024 16:26
@jameslamb jameslamb requested review from a team as code owners August 28, 2024 16:26
@jameslamb jameslamb requested a review from msarahan August 28, 2024 16:26
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

There are some other references in the benchmarks and notebooks. That said, would leave those alone for now. Maybe we can raise an issue so the cuGraph team can follow up (as it may involve rerunning things)

@jakirkham
Copy link
Member

Looks like one CI job had a network failure

That said, cuDF made some changes that we need a fix for in cuGraph. This is already being handled in PR: #4618

So let's wait for that to land and then pull in upstream changes to retest

@jakirkham
Copy link
Member

jakirkham commented Aug 29, 2024

Now that the aforementioned PR is in, updating this PR to include that fix and rerun CI

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good but there are some other issues we could correct at the same time.

docs/cugraph/source/tutorials/cugraph_notebooks.md Outdated Show resolved Hide resolved
docs/cugraph/source/tutorials/cugraph_notebooks.md Outdated Show resolved Hide resolved
notebooks/README.md Outdated Show resolved Hide resolved
notebooks/README.md Outdated Show resolved Hide resolved
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d5154d5 into rapidsai:branch-24.10 Aug 30, 2024
103 checks passed
@jameslamb jameslamb deleted the more-python-upgrades branch August 30, 2024 14:01
@jameslamb
Copy link
Member Author

There are some other references in the benchmarks and notebooks. That said, would leave those alone for now. Maybe we can raise an issue so the cuGraph team can follow up (as it may involve rerunning things)

Sure @jakirkham , happy to. Opened #4640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants