-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix write_json to handle empty string column #16995
Fix write_json to handle empty string column #16995
Conversation
bypass make_strings_children for empty column because when grid size is zero, it throws cuda error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we add tests for this case as well as empty columns for other types?
unit test added. |
Not required. All other types use string functions which checks for empty inputs. Only custom function created in this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit on braces
Co-authored-by: David Wendt <[email protected]>
/merge |
Description
Add empty string column condition for write_json
bypass make_strings_children for empty column because when grid size is zero, it throws cuda error.
Checklist