Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix write_json to handle empty string column #16995

Merged
merged 7 commits into from
Oct 5, 2024
Merged

Fix write_json to handle empty string column #16995

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2341c8f
empty string column condition
karthikeyann Oct 3, 2024
798c047
add unit test
karthikeyann Oct 4, 2024
6d17507
Merge branch 'branch-24.12' into bug-json_writer_empty_string_column
karthikeyann Oct 4, 2024
8b5ab44
add int empty list
karthikeyann Oct 4, 2024
de8699c
Update cpp/src/io/json/write_json.cu
mhaseeb123 Oct 4, 2024
a9b040f
Merge branch 'branch-24.12' into bug-json_writer_empty_string_column
mhaseeb123 Oct 4, 2024
f2037b0
Minor style fix
mhaseeb123 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/src/io/json/write_json.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ struct escape_strings_fn {
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
if (column_v.size() == 0) // empty begets empty
return make_empty_column(type_id::STRING);
karthikeyann marked this conversation as resolved.
Show resolved Hide resolved
auto [offsets_column, chars] =
cudf::strings::detail::make_strings_children(*this, column_v.size(), stream, mr);

Expand Down
Loading