Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nvcomp wheel instead of bundling nvcomp #16946

Merged
merged 13 commits into from
Oct 2, 2024
Prev Previous commit
Next Next commit
Make rpath usage configurable
KyleFromNVIDIA committed Sep 30, 2024
commit 08f13691127997ca0ba758c4fe20e67ba0d479b7
1 change: 1 addition & 0 deletions ci/build_wheel_libcudf.sh
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@ set -euo pipefail

package_dir="python/libcudf"

export SKBUILD_CMAKE_ARGS="-DUSE_CUDA_NVCOMP_WHEEL=ON"
KyleFromNVIDIA marked this conversation as resolved.
Show resolved Hide resolved
./ci/build_wheel.sh ${package_dir}

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"
16 changes: 10 additions & 6 deletions python/libcudf/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -22,6 +22,8 @@ project(
LANGUAGES CXX
)

option(USE_CUDA_NVCOMP_WHEEL "Use the CUDA nvcomp wheel instead of the system library" OFF)
KyleFromNVIDIA marked this conversation as resolved.
Show resolved Hide resolved

# Check if cudf is already available. If so, it is the user's responsibility to ensure that the
# CMake package is also available at build time of the Python cudf package.
find_package(cudf "${RAPIDS_VERSION}")
@@ -45,9 +47,11 @@ set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib)

add_subdirectory(../../cpp cudf-cpp)

set(rpaths "$ORIGIN/../../nvidia/nvcomp")
set_property(
TARGET cudf
PROPERTY INSTALL_RPATH ${rpaths}
APPEND
)
if(USE_CUDA_NVCOMP_WHEEL)
set(rpaths "$ORIGIN/../../nvidia/nvcomp")
set_property(
TARGET cudf
PROPERTY INSTALL_RPATH ${rpaths}
APPEND
)
endif()