Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nvcomp wheel instead of bundling nvcomp #16946

Merged
merged 13 commits into from
Oct 2, 2024
Merged

Use nvcomp wheel instead of bundling nvcomp #16946

merged 13 commits into from
Oct 2, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Contributes to https://github.com/rapidsai/rapids-wheels-planning/issues/74

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 27, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner September 27, 2024 18:18
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 27, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as draft September 27, 2024 19:23
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Sep 27, 2024
bdice
bdice reviewed Sep 30, 2024
View reviewed changes
ci/build_wheel_libcudf.sh Outdated Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
dependencies.yaml Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

@bdice I've applied your suggestions to rapidsai/kvikio#478 too.

@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review October 1, 2024 16:36
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners October 1, 2024 16:36
bdice
bdice reviewed Oct 1, 2024
View reviewed changes
ci/build_wheel_libcudf.sh Outdated Show resolved Hide resolved
bdice
bdice approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question on the CMake variable name.

vyasr
vyasr approved these changes Oct 1, 2024
View reviewed changes
ci/build_wheel_libcudf.sh Outdated Show resolved Hide resolved
python/libcudf/CMakeLists.txt Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a6ca0f0 into rapidsai:branch-24.12 Oct 2, 2024
100 checks passed
@pxLi pxLi mentioned this pull request Oct 2, 2024
Closed
@jlowe jlowe mentioned this pull request Oct 3, 2024
Closed
@jlowe
Copy link
Member

jlowe commented Oct 3, 2024

Note that this has broken downstream projects that build from a libcudf installed area since nvcomp is no longer installed alongside libcudf artifacts. See #16986.

@jameslamb jameslamb mentioned this pull request Oct 30, 2024
Merged
@jameslamb jameslamb mentioned this pull request Nov 7, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Nov 8, 2024
@jameslamb
remove WheelHelpers.cmake (#17276)
c46cf76 
Related to rapidsai/build-planning#33 and rapidsai/build-planning#74

The last use of CMake function `install_aliased_imported_targets()` here was removed in #16946. This proposes removing the file holding its definition.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #17276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/ci-codeowners

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KyleFromNVIDIA @jlowe @robertmaynard @vyasr @bdice @jameslamb