Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce wheel build verbosity, narrow deprecation warning filter #16896

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 24, 2024

Description

Proposes some small changes I've taken as follow-ups from previous work here.

Notes for Reviewers

This is intentionally targeted at 24.12. No need to rush this into 24.10 before code freeze.

How I tested this

locally in docker (click me)
docker run \
    --rm \
    --gpus 1 \
    -v $(pwd):/opt/work \
    -w /opt/work \
    -it rapidsai/citestwheel:latest \
    bash

pip install \
    --prefer-binary \
    'cudf-cu12[test]==24.10.*,>=0.0.0a0' \
    'flask' \
    'flask-cors' \
    'moto>=4.0.8' \
    'boto3' \
    's3fs>=2022.3.0'

cd ./python/cudf

pytest \
    cudf/tests/test_s3.py

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 24, 2024
@jameslamb jameslamb requested review from a team as code owners September 24, 2024 19:39
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 24, 2024
@jameslamb jameslamb changed the title reduce wheel build verbosity, narrow deprecation warning suppression reduce wheel build verbosity, narrow deprecation warning filter Sep 24, 2024
@vyasr
Copy link
Contributor

vyasr commented Sep 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9125d2f into rapidsai:branch-24.12 Sep 27, 2024
99 checks passed
@jameslamb jameslamb deleted the misc/ci-cleanup branch September 27, 2024 15:01
copy-pr-bot bot pushed a commit that referenced this pull request Sep 28, 2024
Proposes some small changes I've taken as follow-ups from previous work here.

* #16745 filtered out all linter warnings about uses of `datetime.utcnow()` ... this PR limits that to only the warnings observed from `botocore` (so that the linter will helpfully warn us about such uses directly in `cudf`)
  - ref #16745 (comment)
* reduces the verbosity of logs for wheel builds (`-vvv` to `-v`)
  - similar to rapidsai/cugraph#4651

## Notes for Reviewers

This is intentionally targeted at `24.12`. No need to rush this into 24.10 before code freeze.

### How I tested this

<details><summary>locally in docker (click me)</summary>

```shell
docker run \
    --rm \
    --gpus 1 \
    -v $(pwd):/opt/work \
    -w /opt/work \
    -it rapidsai/citestwheel:latest \
    bash

pip install \
    --prefer-binary \
    'cudf-cu12[test]==24.10.*,>=0.0.0a0' \
    'flask' \
    'flask-cors' \
    'moto>=4.0.8' \
    'boto3' \
    's3fs>=2022.3.0'

cd ./python/cudf

pytest \
    cudf/tests/test_s3.py
```

</details>

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants