Skip to content

Commit

Permalink
reduce wheel build verbosity, narrow deprecation warning filter (#16896)
Browse files Browse the repository at this point in the history
Proposes some small changes I've taken as follow-ups from previous work here.

* #16745 filtered out all linter warnings about uses of `datetime.utcnow()` ... this PR limits that to only the warnings observed from `botocore` (so that the linter will helpfully warn us about such uses directly in `cudf`)
  - ref #16745 (comment)
* reduces the verbosity of logs for wheel builds (`-vvv` to `-v`)
  - similar to rapidsai/cugraph#4651

## Notes for Reviewers

This is intentionally targeted at `24.12`. No need to rush this into 24.10 before code freeze.

### How I tested this

<details><summary>locally in docker (click me)</summary>

```shell
docker run \
    --rm \
    --gpus 1 \
    -v $(pwd):/opt/work \
    -w /opt/work \
    -it rapidsai/citestwheel:latest \
    bash

pip install \
    --prefer-binary \
    'cudf-cu12[test]==24.10.*,>=0.0.0a0' \
    'flask' \
    'flask-cors' \
    'moto>=4.0.8' \
    'boto3' \
    's3fs>=2022.3.0'

cd ./python/cudf

pytest \
    cudf/tests/test_s3.py
```

</details>

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16896
  • Loading branch information
jameslamb authored and lamarrr committed Sep 28, 2024
1 parent 39f40d5 commit 46665fd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ci/build_wheel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ rapids-generate-version > ./VERSION

cd "${package_dir}"

python -m pip wheel . -w dist -vvv --no-deps --disable-pip-version-check
python -m pip wheel . -w dist -v --no-deps --disable-pip-version-check
2 changes: 1 addition & 1 deletion python/cudf/cudf/tests/pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ filterwarnings =
ignore:::.*xdist.*
ignore:::.*pytest.*
# some third-party dependencies (e.g. 'boto3') still using datetime.datetime.utcnow()
ignore:.*datetime.*utcnow.*scheduled for removal.*:DeprecationWarning
ignore:.*datetime.*utcnow.*scheduled for removal.*:DeprecationWarning:botocore
# Deprecation warning from Pyarrow Table.to_pandas() with pandas-2.2+
ignore:Passing a BlockManager to DataFrame is deprecated:DeprecationWarning
# PerformanceWarning from cupy warming up the JIT cache
Expand Down
2 changes: 1 addition & 1 deletion python/dask_cudf/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ filterwarnings = [
"error::FutureWarning",
"error::DeprecationWarning",
# some third-party dependencies (e.g. 'boto3') still using datetime.datetime.utcnow()
"ignore:.*datetime.*utcnow.*scheduled for removal:DeprecationWarning",
"ignore:.*datetime.*utcnow.*scheduled for removal:DeprecationWarning:botocore",
"ignore:create_block_manager_from_blocks is deprecated and will be removed in a future version. Use public APIs instead.:DeprecationWarning",
# https://github.com/dask/partd/blob/main/partd/pandas.py#L198
"ignore:Passing a BlockManager to DataFrame is deprecated and will raise in a future version. Use public APIs instead.:DeprecationWarning",
Expand Down

0 comments on commit 46665fd

Please sign in to comment.