Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parquet thrift reader #14097

Merged
merged 31 commits into from
Sep 20, 2023
Merged

Refactor parquet thrift reader #14097

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c3b6422
refactor compact protocol reader
etseidl Sep 12, 2023
e84baf6
use CRTP to get rid of pure virtual
etseidl Sep 12, 2023
fa50d62
Revert "use CRTP to get rid of pure virtual"
etseidl Sep 12, 2023
28d71c0
fix get_uxx functions
etseidl Sep 12, 2023
a474bec
replace pure virtual read_value with std::function
etseidl Sep 12, 2023
9220f35
rework implementation of the `column_orders` field in file meta data
etseidl Sep 12, 2023
9f2e898
clean up
etseidl Sep 12, 2023
a91a196
more cleanup
etseidl Sep 12, 2023
4a677f6
clean up remaining single-line if statements
etseidl Sep 12, 2023
e70b810
Merge branch 'branch-23.10' into refactor_parquet_thrift
etseidl Sep 12, 2023
eb519f2
more consts
etseidl Sep 12, 2023
943be91
what can you apply apart from const...more const!
etseidl Sep 12, 2023
1cfe326
clean up header
etseidl Sep 12, 2023
9823f11
Merge branch 'rapidsai:branch-23.10' into refactor_parquet_thrift
etseidl Sep 13, 2023
ac7b665
add FIXME
etseidl Sep 14, 2023
76f16dd
Merge branch 'refactor_parquet_thrift' of github.com:etseidl/cudf int…
etseidl Sep 14, 2023
4f49ef1
Merge branch 'branch-23.10' into refactor_parquet_thrift
etseidl Sep 14, 2023
e757616
add documentation to empty struct functor
etseidl Sep 14, 2023
13200ff
clean up skip_struct_field some more
etseidl Sep 14, 2023
8a4820b
Merge branch 'rapidsai:branch-23.10' into refactor_parquet_thrift
etseidl Sep 15, 2023
5700b21
convert union to enum with state
etseidl Sep 18, 2023
45f3249
Merge branch 'branch-23.10' into refactor_parquet_thrift
etseidl Sep 18, 2023
0ade852
use thrust::optional rather than std::optional as some fields may
etseidl Sep 18, 2023
aac2f33
Merge branch 'branch-23.10' into refactor_parquet_thrift
etseidl Sep 18, 2023
0ae2fc4
missed a use of std::optional
etseidl Sep 18, 2023
f429be4
change field_val to non-const and private as suggested in review
etseidl Sep 19, 2023
3949810
more snake case
etseidl Sep 19, 2023
c5e1267
change name of func as suggested in review
etseidl Sep 19, 2023
7be284c
Merge branch 'branch-23.10' into refactor_parquet_thrift
etseidl Sep 19, 2023
9e132b4
make another const member private
etseidl Sep 19, 2023
e192a23
simplify logic for bools
etseidl Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading