Code

Refactor parquet thrift reader#14097

Code

Merged

rapids-bot[bot] merged 31 commits intorapidsai:branch-23.10rapidsai/cudf:branch-23.10from etseidl:refactor_parquet_thriftetseidl/cudf:refactor_parquet_thriftCopy head branch name to clipboardSep 20, 2023

+662-706

Commits

Commits on Sep 12, 2023

• refactor compact protocol reader

  etseidl

  committed
  c3b6422

• use CRTP to get rid of pure virtual

  etseidl

  committed
  e84baf6

• Revert "use CRTP to get rid of pure virtual"

  Show description for fa50d62
  etseidl

  committed
  fa50d62

• fix get_uxx functions

  etseidl

  committed
  28d71c0

• replace pure virtual read_value with std::function

  etseidl

  committed
  a474bec

• rework implementation of the column_orders field in file meta data

  Show description for 9220f35
  etseidl

  committed
  9220f35

• clean up

  etseidl

  committed
  9f2e898

• more cleanup

  etseidl

  committed
  a91a196

• clean up remaining single-line if statements

  etseidl

  committed
  4a677f6

• Merge branch 'branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  e70b810

• more consts

  etseidl

  committed
  eb519f2

• what can you apply apart from const...more const!

  Show description for 943be91
  etseidl

  committed
  943be91

• clean up header

  etseidl

  committed
  1cfe326

Commits on Sep 13, 2023

• Merge branch 'rapidsai:branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  9823f11

Commits on Sep 14, 2023

• add FIXME

  etseidl

  committed
  ac7b665

• Merge branch 'refactor_parquet_thrift' of github.com:etseidl/cudf into refactor_parquet_thrift

  etseidl

  committed
  76f16dd

• Merge branch 'branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  4f49ef1

• add documentation to empty struct functor

  etseidl

  committed
  e757616

• clean up skip_struct_field some more

  etseidl

  committed
  13200ff

Commits on Sep 15, 2023

• Merge branch 'rapidsai:branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  8a4820b

Commits on Sep 18, 2023

• convert union to enum with state

  etseidl

  committed
  5700b21

• Merge branch 'branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  45f3249

• use thrust::optional rather than std::optional as some fields may

  Show description for 0ade852
  etseidl

  committed
  0ade852

• Merge branch 'branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  aac2f33

• missed a use of std::optional

  etseidl

  committed
  0ae2fc4

Commits on Sep 19, 2023

• change field_val to non-const and private as suggested in review

  etseidl

  committed
  f429be4

• more snake case

  etseidl

  committed
  3949810

• change name of func as suggested in review

  etseidl

  committed
  c5e1267

• Merge branch 'branch-23.10' into refactor_parquet_thrift

  etseidl

  authored
  7be284c

• make another const member private

  etseidl

  committed
  9e132b4

• simplify logic for bools

  etseidl

  committed
  e192a23