Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vdi-setup.md #1366

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update vdi-setup.md #1366

merged 1 commit into from
Jan 16, 2025

Conversation

Ukonhattu
Copy link
Contributor

@Ukonhattu Ukonhattu commented Jan 16, 2025

Change VMWare Horizon mentions and link to Omnissa Horizon.

Summary by CodeRabbit

  • Documentation
    • Updated VDI setup documentation to reflect new client name from VMware to Omnissa
    • Updated download link and client references accordingly

Change VMWare Horizon mentions and link to Omnissa Horizon.
@Ukonhattu Ukonhattu requested a review from nygrenh January 16, 2025 10:52
Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

Walkthrough

The documentation for Virtual Desktop Infrastructure (VDI) setup has been updated to reflect a change from VMware Horizon Client to Omnissa Horizon Client. The modifications include updating the section title, download link, and client references throughout the document, while maintaining the overall structure and instructions for the VDI setup process.

Changes

File Changes
docs/vdi-setup.md - Renamed section title from "VMware Horizon Client" to "Omnissa Horizon Client"
- Updated download link to Omnissa site
- Replaced all "VMware Horizon Client" references with "Omnissa Horizon Client"

Poem

🐰 A Rabbit's Ode to Client Rename

From VMware to Omnissa's domain,
A client's journey, a software refrain,
Links updated, names rearranged,
Our VDI setup, subtly changed!
Hop along, tech world, embrace the new name! 🖥️


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs label Jan 16, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f265c3d and a764d49.

📒 Files selected for processing (1)
  • docs/vdi-setup.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: headless_lms
  • GitHub Check: build-and-deploy
  • GitHub Check: build
  • GitHub Check: code-style
🔇 Additional comments (2)
docs/vdi-setup.md (2)

17-17: Verify download link and update link text

Please verify:

  1. The download URL customerconnect.omnissa.com - is this the correct domain?
  2. The link text still says "VMware Horizon Client Downloads" and should be updated to "Omnissa Horizon Client Downloads"

15-22: Verify the switch from VMware to Omnissa Horizon

Given that this is a significant change from the well-known VMware Horizon to Omnissa Horizon:

  1. Has this change been approved by the relevant stakeholders?
  2. Is there any additional context or documentation about this transition that should be referenced?
  3. Should we add a note about this being a transition from VMware Horizon?

2. Install the client software on your machine.
3. Open VMware Horizon Client and select **New Server**.
3. Open Omnissa Horizon Client and select **New Server**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update remaining VMware reference in tip section

The tip section below the instructions still contains a reference to "VMware Horizon Client":

-> **Tip**: You can also access the virtual desktop through [https://vdi.helsinki.fi](https://vdi.helsinki.fi), but using the VMware Horizon Client is recommended for better performance and features.
+> **Tip**: You can also access the virtual desktop through [https://vdi.helsinki.fi](https://vdi.helsinki.fi), but using the Omnissa Horizon Client is recommended for better performance and features.

Also applies to: 22-22

@nygrenh nygrenh merged commit e636db2 into master Jan 16, 2025
17 of 18 checks passed
@nygrenh nygrenh deleted the vmware_omnissa_horizon-patch branch January 16, 2025 11:51
@coderabbitai coderabbitai bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants