Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix sub-package level meta #4037

Closed
wants to merge 1 commit into from
Closed

WIP: fix sub-package level meta #4037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/python/quilt3/packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,6 +1540,9 @@
new_entry.hash = dict(type=SHA256_CHUNKED_HASH_NAME, value=checksum)
pkg._set(logical_key, new_entry)

for lk, meta in self._walk_dir_meta():
pkg._ensure_subpackage(self._split_key(lk[:-1])).set_meta(meta)

Check warning on line 1544 in api/python/quilt3/packages.py

View check run for this annotation

Codecov / codecov/patch/informational

api/python/quilt3/packages.py#L1544 

Added line #L1544 was not covered by tests

# Some entries may miss hash values (e.g because of selector_fn), so we need
# to fix them before calculating the top hash.
pkg._calculate_missing_hashes()
Expand Down