Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix sub-package level meta #4037

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: fix sub-package level meta #4037

wants to merge 1 commit into from

Conversation

sir-sigurd
Copy link
Member

@sir-sigurd sir-sigurd commented Jun 28, 2024

Description

TODO

  • user_meta vs meta?
  • use sub-package level meta for top hash
  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.43%. Comparing base (ee0aea3) to head (2d89857).
Report is 2 commits behind head on master.

Files Patch % Lines
api/python/quilt3/packages.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4037   +/-   ##
=======================================
  Coverage   38.43%   38.43%           
=======================================
  Files         718      718           
  Lines       33051    33053    +2     
  Branches     4842     4842           
=======================================
+ Hits        12704    12705    +1     
- Misses      19196    19197    +1     
  Partials     1151     1151           
Flag Coverage Δ
api-python 90.74% <50.00%> (-0.02%) ⬇️
catalog 11.50% <ø> (ø)
lambda 87.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant