Disable the in-browser autocomplete for the search input #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 1aa9526 has been successfully built and deployed to https://quarkus-site-pr-1943-preview.surge.sh
|
gsmet
approved these changes
Apr 16, 2024
yrodiere
force-pushed
the
disable-autocomplete-on-search-input
branch
from
a12da57 to
1d43bf5
Compare
|
Rebased and merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes quarkusio/search.quarkus.io#231
I think we should keep the
qname, as it's also the API parameter. And if we'd wanted to have autocomplete working for the field then we should consider something backed by the search service.. though I'm not sure it would be much helpful in this case.