Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird proposal from the browser in the search field #231

Closed
gsmet opened this issue Apr 12, 2024 · 5 comments · Fixed by quarkusio/quarkusio.github.io#1943
Closed

Weird proposal from the browser in the search field #231

gsmet opened this issue Apr 12, 2024 · 5 comments · Fixed by quarkusio/quarkusio.github.io#1943

Comments

@gsmet
Copy link
Member

gsmet commented Apr 12, 2024

I'm not sure where it comes from but I searched for Hibernate ORM once and then I had this weird popup suggesting hibernate-orm.

Not sure if it's a browser thing or something coming from the script but it's a bit annoying.
Screenshot from 2024-04-12 18-06-20

@marko-bekhta
Copy link
Collaborator

😔 I think it's from the browser on inputs .... if autocomplete="off" attribute is added to that input the popup does not showup

@gsmet
Copy link
Member Author

gsmet commented Apr 12, 2024

In that very case, I'm not sure it was very weird. (I was in the weird state I described in another issue and whatever I typed didn't get any search done).

I just tried again and I had:

Screenshot from 2024-04-12 18-32-30

Which is less than ideal as it apparently reuses the searches from GitHub (this looks very very odd as I would expect this to be per website).

I'm not sure if we should disable autocomplete here (maybe?) but in any case we should probably not use q to avoid a conflict with GitHub q.

I'm not sure autocomplete has a lot of value in this case.

@yrodiere
Copy link
Member

Not sure if it's a browser thing or something coming from the script but it's a bit annoying.

Definitely a browser thing, I get this on plenty of websites.

I'm not sure if we should disable autocomplete here (maybe?) but in any case we should probably not use q to avoid a conflict with GitHub q.

Agreed, let's rename q to something else, or let @ia3andy find the magic option to tell browsers "don't mix suggestions on this field with data from other websites" :)

@ia3andy
Copy link
Collaborator

ia3andy commented Apr 16, 2024

If we rename it, this means we should also rename it on the search api.. unless we do some kind of magical mapping. I'll look if we can ignore those proposal some way.

@marko-bekhta
Copy link
Collaborator

If we rename it, this means we should also rename it on the search api.. unless we do some kind of magical mapping. I'll look if we can ignore those proposal some way.

quarkusio/quarkusio.github.io#1943 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants