-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3223][ADD] website_sale_address_name_description #247
[3223][ADD] website_sale_address_name_description #247
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## 15.0 #247 +/- ##
=======================================
Coverage 69.15% 69.15%
=======================================
Files 173 173
Lines 1378 1378
Branches 154 154
=======================================
Hits 953 953
Misses 395 395
Partials 30 30 |
ab0cb83
to
02bb197
Compare
<span>(Name, Company Name)</span> | ||
</xpath> | ||
<xpath expr="//input[@name='name']" position="after"> | ||
<t t-out="request.env.company.address_name_text" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use odoo standard address fields instead of adding new field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review.
This field is not an address, but text to add a note by the address.
Add a note like this.
"If you enter the name of yor company, be sure to enter the name of the person in charge as well."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
class ResCompany(models.Model): | ||
_inherit = "res.company" | ||
|
||
address_name_text = fields.Html(translate=True, sanitize=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kanda999 Can you please check if removing sanitize=False
will cause any inconveniences? I vaguely remember having some minor issue with sanitization in an older version, but it may not be relevant anymore. ref. odoo/odoo#116364 (comment)
#. module: website_sale_address_name_description | ||
#: model_terms:ir.ui.view,arch_db:website_sale_address_name_description.address | ||
msgid "<span>(Name, Company Name)</span>" | ||
msgstr "<span>(お名前, 会社名)</span>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "<span>(お名前, 会社名)</span>" | |
msgstr "<span>(お名前, 会社名)</span>" |
3223