Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3223][ADD] website_sale_address_name_description #247

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

kanda999
Copy link
Contributor

@kanda999 kanda999 commented Jul 5, 2023

@kanda999 kanda999 changed the title [][ADD] website_sale_address_name_description [3223][ADD] website_sale_address_name_description Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #247 (751be09) into 15.0 (4f3c333) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             15.0     #247   +/-   ##
=======================================
  Coverage   69.15%   69.15%           
=======================================
  Files         173      173           
  Lines        1378     1378           
  Branches      154      154           
=======================================
  Hits          953      953           
  Misses        395      395           
  Partials       30       30           

@kanda999 kanda999 force-pushed the 15.0-add-website_sale_address_name_description branch from ab0cb83 to 02bb197 Compare July 5, 2023 09:31
@kanda999
Copy link
Contributor Author

kanda999 commented Jul 5, 2023

Current view
2023-07-05_18h24_53

<span>(Name, Company Name)</span>
</xpath>
<xpath expr="//input[@name='name']" position="after">
<t t-out="request.env.company.address_name_text" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use odoo standard address fields instead of adding new field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review.
This field is not an address, but text to add a note by the address.

Add a note like this.
"If you enter the name of yor company, be sure to enter the name of the person in charge as well."

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

class ResCompany(models.Model):
_inherit = "res.company"

address_name_text = fields.Html(translate=True, sanitize=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanda999 Can you please check if removing sanitize=False will cause any inconveniences? I vaguely remember having some minor issue with sanitization in an older version, but it may not be relevant anymore. ref. odoo/odoo#116364 (comment)

#. module: website_sale_address_name_description
#: model_terms:ir.ui.view,arch_db:website_sale_address_name_description.address
msgid "<span>(Name, Company Name)</span>"
msgstr "<span>(お名前, 会社名)</span>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "<span>お名前, 会社名</span>"
msgstr "<span>(お名前, 会社名)</span>"

@kanda999 kanda999 merged commit 8e08371 into 15.0 Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants