Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duty Blip change when inside a vehicle #431

Closed
wants to merge 4 commits into from

Conversation

AnishBplayz
Copy link

This PR is for enhancing QOL stuff and main objective for the change is

To differentiate the duty blip from in a vehicle and out of vehicle

So when you sit inside a vehicle the blip turns into a car and heads accordingly and vice versa when on foot it stays default.

Copy link

@Ranjit-Develops Ranjit-Develops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link

@Jamie9192 Jamie9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for the local variable? could use if IsPedInAnyVehicle(ped) then

as its not used again?

@AnishBplayz
Copy link
Author

There can be more additions done using this local variable and I don't think using a local variable to define that could be a big issue bruh

What is the reason for the local variable? could use if IsPedInAnyVehicle(ped) then

as its not used again?

@Jamie9192
Copy link

There can be more additions done using this local variable and I don't think using a local variable to define that could be a big issue bruh

What is the reason for the local variable? could use if IsPedInAnyVehicle(ped) then
as its not used again?

No big issue at all. just pointless code bud

@Ranjit-Develops
Copy link

Ranjit-Develops commented Dec 28, 2022

Yeah Actually Local Variable help you avoid cluttering But If It's Only one Then It's Also Fine He Was Just Suggesting You right? @Jamie9192

@Ranjit-Develops
Copy link

And If A Config would Be There It would be Pretty Nice 👍🏻

@r0adra93
Copy link

r0adra93 commented Jan 4, 2023

moved duty-blips to QB-Jobs

@AnishBplayz
Copy link
Author

@r0adra93 Check qb-jobs PR added it there too for all the jobs but for time being until its unavailable to use people can use this for now and until then it can be merged too unless the code is wiped from here

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This PR has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Oct 6, 2023
@github-actions github-actions bot removed the Stale label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants