Add a few testing helper utilities to pueblo.testing
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 71.98% 74.37% +2.39%
==========================================
Files 14 17 +3
Lines 514 562 +48
==========================================
+ Hits 370 418 +48
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
amotl
force-pushed
the
testing-more
branch
3 times, most recently
from
30d25fa
to
c4f1082
Compare
matriv
reviewed
Nov 7, 2023
matriv
approved these changes
Nov 7, 2023
amotl
commented
Nov 7, 2023
Comment on lines
+25
to
+26
| if item.name in ["conftest.py"] or item.name.startswith("test"): | ||
| continue |
There was a problem hiding this comment.
Currently untested, so this is a candidate for improving the test cases.
Comment on lines
+42
to
+43
| if not tests: | ||
| raise ValueError(f"No tests collected from notebook: {filepath}") |
There was a problem hiding this comment.
Currently untested, so this is a candidate for improving the test cases.
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Classical yak shaving.
Details
A few generalized testing helpers to avoid code duplication within the educational repository cratedb-examples, originally conceived at 1. We need those utilities at many more spots, so we needed to find a good place to store them.
/cc @andnig
Footnotes
https://github.com/crate/cratedb-examples/blob/main/topic/machine-learning/llm-langchain/test.py ↩