Add SQL runner utility .io.sql.run_sql
#74
Merged
+113
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/add-run-sql
branch
2 times, most recently
from
dfd535f
to
71e67ff
Compare
amotl
changed the title
cratedb_toolkit.shell.run_sql utility primitivecratedb_toolkit.io.sql.run_sql utility primitive
amotl
force-pushed
the
amo/add-run-sql
branch
2 times, most recently
from
ead3c71
to
d604d81
Compare
amotl
changed the title
cratedb_toolkit.io.sql.run_sql utility primitive.io.sql.run_sql
amotl
force-pushed
the
amo/add-run-sql
branch
from
d604d81
to
c8336ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
amotl
force-pushed
the
amo/add-run-sql
branch
2 times, most recently
from
d7bae2d
to
108a992
Compare
amotl
force-pushed
the
amo/add-run-sql
branch
from
108a992
to
486e720
Compare
This was referenced Nov 7, 2023
matriv
approved these changes
Nov 8, 2023
seut
reviewed
Nov 8, 2023
Comment on lines
+35
to
+43
| sql_effective: str | ||
| if isinstance(sql, str): | ||
| sql_effective = sql | ||
| elif isinstance(sql, Path): | ||
| sql_effective = sql.read_text() | ||
| elif isinstance(sql, io.IOBase): | ||
| sql_effective = sql.read() | ||
| else: | ||
| raise TypeError("SQL statement type must be either string, Path, or IO handle") |
There was a problem hiding this comment.
Just curious: couldn't this be done by using function overloads with @typing.overload() instead?
There was a problem hiding this comment.
Hi. I have to admit I never used it. If you think the code can be improved, I will be happy to learn about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Classical yak shaving.
Details
Similar to pyveci/pueblo#12, this patch adds a generalized testing helper function to avoid code duplication within the educational repository cratedb-examples, originally conceived at 1. We need this utility function at many more spots, so we needed to find a good place to store it.
Synopsis
Notes
Note that details on the interface may change while we go, specifically on the "naming things" / DWIM side of things. If you have any suggestions, feel free to add your voice.
/cc @karynzv, @marijaselakovic, @hlcianfagna, @hammerhead, @WalBeh, @andnig, @ckurze, @vvulf
Footnotes
https://github.com/crate/cratedb-examples/blob/main/topic/machine-learning/llm-langchain/test.py ↩