Align rrelu_with_noise schema to reflect noise mutation [branch] #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKobzarev
force-pushed
the
rrelu_with_noise
branch
from
17a04cd to
75f66b9
Compare
IvanKobzarev
force-pushed
the
rrelu_with_noise
branch
from
75f66b9 to
e2106d3
Compare
IvanKobzarev
force-pushed
the
rrelu_with_noise
branch
from
e2106d3 to
e068402
Compare
IvanKobzarev
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 3, 2024
…tion in compile" Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues. Got a new PR with the same content (ghstack checkout was failing due to changed submodules) Corresponding xla PR: pytorch/xla#8363 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
IvanKobzarev
added a commit
to pytorch/pytorch
that referenced
this pull request
Dec 3, 2024
Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues. Got a new PR with the same content (ghstack checkout was failing due to changed submodules) Corresponding xla PR: pytorch/xla#8363 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
qihqi
approved these changes
Dec 3, 2024
|
Merging later after the torch side PR merges first, then torch_pin file should be removed. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 4, 2024
Rebase-copy of long standing already approved PR #138503 that was blocked on landing by xla build issues. Got a new PR with the same content (ghstack checkout was failing due to changed submodules) Corresponding xla PR: pytorch/xla#8363 Pull Request resolved: #141867 Approved by: https://github.com/bdhirsh
IvanKobzarev
force-pushed
the
rrelu_with_noise
branch
from
e068402 to
f477118
Compare
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…1867) Rebase-copy of long standing already approved PR pytorch#138503 that was blocked on landing by xla build issues. Got a new PR with the same content (ghstack checkout was failing due to changed submodules) Corresponding xla PR: pytorch/xla#8363 Pull Request resolved: pytorch#141867 Approved by: https://github.com/bdhirsh
rpsilva-aws
pushed a commit
to rpsilva-aws/xla
that referenced
this pull request
Dec 6, 2024
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…1867) Rebase-copy of long standing already approved PR pytorch#138503 that was blocked on landing by xla build issues. Got a new PR with the same content (ghstack checkout was failing due to changed submodules) Corresponding xla PR: pytorch/xla#8363 Pull Request resolved: pytorch#141867 Approved by: https://github.com/bdhirsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating instead of #8309
As fork branch can not be used in torch xla commit pin.
pytorch PR is pytorch/pytorch#138503
rrelu_with_noise actually mutates noise, but this was not reflected in schema.
As a result compilation did not capture its mutation.
This PR is to align xla override for rrelu_with_noise to remove const for noise argument