-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align rrelu_with_noise schema to reflect noise mutation #8309
Conversation
Please fix the build error:
You can verify it built or not locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is meant to be land together with pytorch/pytorch#138503
but because of them being 2 different repos, it has to be done one by one.
The current plan is to land this one, land the torch one + xla pin update.
b2430c1
to
2c30729
Compare
@qihqi Thanks for approving. This build error looks like caused from missing |
2c30729
to
17a04cd
Compare
17a04cd
to
801f949
Compare
Abandoning in favor of #8363 (PR not fro fork to be able to use in xla pin in pytorch) |
pytorch PR is pytorch/pytorch#138503
rrelu_with_noise actually mutates noise, but this was not reflected in schema.
As a result compilation did not capture its mutation.
This PR is to align xla override for rrelu_with_noise to remove
const
for noise argument