Fix precision issue of pow(int, float) #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Dec 12, 2023
torch_xla/csrc/tensor_methods.cpp
Outdated
| auto* xla_node = dynamic_cast<XlaNode*>(node.get()); | ||
| at::ScalarType dtype = | ||
| TorchTypeFromXlaType(xla_node->xla_shape().element_type()); | ||
| return input->CreateFrom(node, dtype); |
There was a problem hiding this comment.
I think you can do something similar to input->CreateFrom(node, /*logical_element_type=*/nullptr) to make sure logical_lement_type is not being inherited from input, and it will by defualt use the xla_shape.
wonjoolee95
approved these changes
Dec 12, 2023
qihqi
force-pushed
the
qihqi/pow
branch
8 times, most recently
from
2c8e384 to
e2bafc2
Compare
Currently we are casting float scalar to int32 tensor (to match input1). This is incorrect as it would do power in int and get incorrect results. Fixed version will cast both to float and do the math in float. The return value will be float tensor instead of int tensor
qihqi
added a commit
that referenced
this pull request
Dec 15, 2023
qihqi
added a commit
that referenced
this pull request
Dec 15, 2023
qihqi
added a commit
that referenced
this pull request
Dec 15, 2023
qihqi
added a commit
that referenced
this pull request
Dec 15, 2023
golechwierowicz
pushed a commit
that referenced
this pull request
Jan 12, 2024
bhavya01
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5887