Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126719: Improve math.fmod documentation. #127741

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-126719: Improve math.fmod documentation. #127741

wants to merge 5 commits into from
+2 −1

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Dec 8, 2024 •
edited by github-actions bot
Loading

This change was raised a month ago but has been forgotten about.

#126719

📚 Documentation preview 📚: https://cpython-previews--127741.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 8, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 8, 2024
Open
picnixz
picnixz reviewed Dec 8, 2024
View reviewed changes
Doc/library/math.rst Outdated Show resolved Hide resolved
Doc/library/math.rst Outdated Show resolved Hide resolved
StanFromIreland and others added 2 commits December 8, 2024 17:07
@StanFromIreland @picnixz
Update Doc/library/math.rst
f14e539 
Co-authored-by: Bénédikt Tran <[email protected]>
@StanFromIreland @picnixz
Update Doc/library/math.rst
ccaac54 
Co-authored-by: Bénédikt Tran <[email protected]>
skirpichev
skirpichev requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, that your diff looks much bigger, probably just due to formatting changes.

Please revert unrelated changes.

@StanFromIreland
Copy link
Contributor Author

formatting changes.

@skirpichev The formatting changes are necessary, how do I add them, the line is otherwise too long? Please advise.

@skirpichev
Copy link
Member

I don't think that patch from the issue has "too long" lines.

@StanFromIreland
Remove formatting as per @skirpichev request
e51ea67 
This may be rejected by lint as the line is too long.
picnixz
picnixz reviewed Dec 24, 2024
View reviewed changes
Doc/library/math.rst Outdated Show resolved Hide resolved
@StanFromIreland @picnixz
Update Doc/library/math.rst
f729d6d 
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @skirpichev @picnixz