Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing explanation about math.fmod #126719

Open
Nodd opened this issue Nov 12, 2024 · 3 comments
Open

Missing explanation about math.fmod #126719

Nodd opened this issue Nov 12, 2024 · 3 comments
Labels
docs Documentation in the Doc dir

Comments

@Nodd
Copy link
Contributor

Nodd commented Nov 12, 2024

Documentation

This issue was first raised in a PR, but it is preferred to be modified independently as per this comment. This issue is created to track the modification to add it later eventually.

This is the proposed modification:

+   Return the remainder of division ``x / y``,
+   as defined by the platform C library function ``fmod(x, y)``.
+
+   Note that the
-   Return ``fmod(x, y)``, as defined by the platform C library. Note that the

Linked PRs

@m3tal10
Copy link

m3tal10 commented Nov 12, 2024

Hey, I am new to Open Source Contributions. Can anyone assign it to me?
I am willing to do this, need help and guidance to start my open-source contribution journey.

@eendebakpt
Copy link
Contributor

eendebakpt commented Nov 12, 2024

Hi @m3tal10 , nice you are willing to help out. We typically do not assign issues to people, but you can start working on the issue and open a PR. Just post a message here you started working on the topic, so other contributors won't start on the same issue.

You can find more information on how to contribute on https://devguide.python.org/. If you need more help, then discourse.python.org is a good place to ask for help.

Also note that a PR has already been opened: #126337. A good start to open source contributions can also be to review the PR and learn from it.

@Nodd
Copy link
Contributor Author

Nodd commented Nov 12, 2024

I would advise to wait for #126337 to be merged, to avoid conflicts. That's the problem with refactoring, conflicts get messy. That's why a created an issue in the first place, and not a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
Status: Todo
Development

No branches or pull requests

3 participants