Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track smart_holder PR #5286: Fix HAVE vs HAS naming mishap (PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT) #172

Merged
merged 1 commit into from
Aug 5, 2024

Commits on Aug 5, 2024

  1. Track smart_holder PR #5286: Fix HAVE vs HAS naming mishap (`PYBI…

    …ND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT`)
    
    pybind/pybind11#5286
    
    Systematic, trivial name change:
    
    ```diff
    -PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT
    +PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT
    ```
    
    This is for internal consistency. There are no `PYBIND11_HAVE` macros, but 10 unique `PYBIND11_HAS` macros:
    
    ```
    $ git grep 'define PYBIND11_HAS' | sed 's/.*define PYBIND11_HAS/PYBIND11_HAS/' | cut -d' ' -f1 | sort | uniq
    ```
    ```
    PYBIND11_HAS_EXPERIMENTAL_FILESYSTEM
    PYBIND11_HAS_EXP_OPTIONAL
    PYBIND11_HAS_FILESYSTEM
    PYBIND11_HAS_FILESYSTEM_IS_OPTIONAL
    PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT
    PYBIND11_HAS_OPTIONAL
    PYBIND11_HAS_STD_LAUNDER
    PYBIND11_HAS_STRING_VIEW
    PYBIND11_HAS_U8STRING
    PYBIND11_HAS_VARIANT
    ```
    
    PiperOrigin-RevId: 659556864
    Ralf W. Grosse-Kunstleve authored and copybara-github committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c97654e View commit details
    Browse the repository at this point in the history