Track smart_holder PR #5286: Fix HAVE vs HAS naming mishap (PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT)
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/659316612
branch
from
60e9350
to
5f5d937
Compare
…ND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT`) pybind/pybind11#5286 Systematic, trivial name change: ```diff -PYBIND11_HAVE_INTERNALS_WITH_SMART_HOLDER_SUPPORT +PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT ``` This is for internal consistency. There are no `PYBIND11_HAVE` macros, but 10 unique `PYBIND11_HAS` macros: ``` $ git grep 'define PYBIND11_HAS' | sed 's/.*define PYBIND11_HAS/PYBIND11_HAS/' | cut -d' ' -f1 | sort | uniq ``` ``` PYBIND11_HAS_EXPERIMENTAL_FILESYSTEM PYBIND11_HAS_EXP_OPTIONAL PYBIND11_HAS_FILESYSTEM PYBIND11_HAS_FILESYSTEM_IS_OPTIONAL PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT PYBIND11_HAS_OPTIONAL PYBIND11_HAS_STD_LAUNDER PYBIND11_HAS_STRING_VIEW PYBIND11_HAS_U8STRING PYBIND11_HAS_VARIANT ``` PiperOrigin-RevId: 659556864
copybara-service
bot
force-pushed
the
cl/659316612
branch
from
5f5d937
to
c97654e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track smart_holder PR #5286: Fix
HAVEvsHASnaming mishap (PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT)pybind/pybind11#5286
Systematic, trivial name change:
This is for internal consistency. There are no
PYBIND11_HAVEmacros, but 10 uniquePYBIND11_HASmacros: