Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist initial Pusher options #783

Merged

Conversation

kamalbennani
Copy link

@kamalbennani kamalbennani commented Nov 29, 2023

What does this PR do?

Initial Pusher Options passed to the constructor were ignored when calling pusher.switchCluster.

Checklist

  • All new functionality has tests.
  • All tests are passing.
  • New or changed API methods have been documented.
  • npm run format has been run

CHANGELOG

@kamalbennani kamalbennani changed the base branch from master to releases/v8.4.0 November 29, 2023 22:02
@kamalbennani kamalbennani force-pushed the fix/persist-initial-options branch from 648d563 to 59dfb65 Compare November 29, 2023 22:07
@kamalbennani
Copy link
Author

Hi @MeenaAlfons, Can we have this reviewed and maybe released as rc2 🙇
Thank you buddy!

@kamalbennani kamalbennani force-pushed the fix/persist-initial-options branch from 59dfb65 to f59dac4 Compare November 29, 2023 22:12
@kamalbennani kamalbennani mentioned this pull request Nov 29, 2023
4 tasks
@MeenaAlfons
Copy link
Contributor

MeenaAlfons commented Nov 30, 2023

Yup, I remember we had a #773 (comment) about that. 😅 It seems that it got missed in later changes. That's fine. It's good that we made a release candidate.

In addition to me reviewing the PR, could you please test this version using its commit git://github.com/kamalbennani/pusher-js.git#f59dac4 before we make another release candidate?

If you are using any of these, consider testing them before and after switchCluster:

  • Private Channels
  • Presence Channels
  • User Authentication
  • Server-to-user messages
  • Watchlist Online Status

Thank you 🙏

@kamalbennani
Copy link
Author

Hi @MeenaAlfons,
Yeah I had the changes on my local patch, but forgot to push them to the SDK.
I've tested Private and Presence Channels and it's working perfectly.
Would you mind conducting some tests on your end as well?

@kamalbennani
Copy link
Author

Hi, @MeenaAlfons
The changes have been fully tested and everything seems to work just fine.
Would it be possible to release it as part of rc2? please.
Thanks

@MeenaAlfons MeenaAlfons merged commit 6fe1ce6 into pusher:releases/v8.4.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants