[types] Invalid type definition for channelAuthorization with customHandler

[msamsel]

I noticed the issue when I tried to migrate the legacy authorizer to the newer customHandler.
It looks like when I define a customHandler, the type definition still requires providing transport and endpoint fields in channelAuthorization object. It doesn't look as if theses 2 have any purpose. Maybe they should be marked as optional if customeHandler is provided? 🤔

[Vap0r1ze]

i thought this was strange too.. for reference, my client definition looks like this:

export const pusherClient = new PusherClient(process.env.NEXT_PUBLIC_PUSHER_KEY, {
    cluster: process.env.NEXT_PUBLIC_PUSHER_CLUSTER,
    channelAuthorization: {
        endpoint: '', // doesn't seem needed
        transport: 'ajax', // doesn't seem needed
        customHandler: async (channelInfo, callback) => {
            trpcProxy.pusher.authorize.query(channelInfo)
                .then(auth => callback(null, auth))
                .catch(err => callback(err, null));
        },
    },
    userAuthentication: {
        endpoint: '', // doesn't seem needed
        transport: 'ajax', // doesn't seem needed
        customHandler: async ({ socketId }, callback) => {
            trpcProxy.pusher.authenticate.query({ socketId })
                .then(auth => callback(null, auth))
                .catch(err => callback(err, null));
        },
    },
});

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you'd like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.

[bstst]

same here. need to do this so it does not complain:

[kamalbennani]

Those fields are indeed not needed, I provided a fix in this PR.

[kamalbennani]

This is now fixed in >= v8.4.0-rc2